k3nny/TISbackup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
206 Commits 3 Branches 0 Tags
a768d95ed3674705fa52c9f3d1579eb978246766
Commit Graph
20 Commits
Author SHA1 Message Date
k3nnyandClaude 6c68b5339e fix(security): replace os.popen/os.system with subprocess for command injection prevention 
Replace all deprecated and unsafe command execution methods with
secure subprocess.run() calls using list arguments.

Changes:
- Replace os.popen() with subprocess.run() in tisbackup_gui.py
- Replace os.system() with subprocess.run() in tasks.py and backup_xva.py
- Add input validation for device/partition names (regex-based)
- Fix file operations to use context managers (with statement)
- Remove wildcard import from shutil
- Add timeout protection to all subprocess calls (5-30s)
- Improve error handling with proper try/except blocks

Security improvements:
- Prevent command injection vulnerabilities in USB disk operations
- Validate device paths with regex before system calls
- Use list arguments instead of shell=True to prevent injection
- Add proper error handling instead of silent failures

Code quality improvements:
- Replace deprecated os.popen() (deprecated since Python 2.6)
- Use context managers for file operations
- Remove wildcard imports for cleaner namespace
- Add comprehensive error handling and logging

Documentation:
- Add SECURITY_IMPROVEMENTS.md documenting all changes
- Document remaining security issues and recommendations
- Include testing recommendations and migration notes

BREAKING CHANGE: None - all changes are backward compatible

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-05 01:23:53 +02:00
k3nny 737f9bea38 fix iniparse
lint / docker (push) Successful in 9m14s
Details 
fix code passing ruff linter
pre-commit ruff
pre-commit ruff format
 2024-11-29 23:45:40 +01:00
k3nny 99dc6e0abf fix import 2024-11-28 23:46:48 +01:00
htouvet bc4b9811ed migrate to Python3 (from alejeune) 2022-04-25 10:02:43 +02:00
ssamson-tis 2853903232 Fix export xva with Xenserver > 7.1 2017-07-24 18:23:15 +02:00
ssamson-tis 3d9bd21a7b Revert "Revert "- fix use_compression"" 
This reverts commit 3a6b93c85d.
 2015-12-23 11:43:28 +01:00
ssamson-tis 3a6b93c85d Revert "- fix use_compression" 
This reverts commit f88c9d1d06.
 2015-12-23 11:42:55 +01:00
ssamson-tis f88c9d1d06 - fix use_compression 2015-10-30 15:19:47 +01:00
ssamson-tis e8708f1efa Delete timeout with use_compression 2015-10-20 10:22:40 +02:00
ssamson-tis efb08d757f Compress xva export 2015-07-28 10:48:45 +02:00
ssamson-tis 464c9dd9b1 fix compatibility with old python versions 2015-07-03 16:18:00 +02:00
ssamson-tis 14cdc6d4f9 Ignore proxies for export xva 2015-06-30 11:18:11 +02:00
ssamson-tis 1137263ef4 Fix: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581) 2015-06-30 10:31:32 +02:00
ssamson-tis 07bb5d7de6 Bugfix: register_existing 2015-04-01 16:37:47 +02:00
Jérémie Courrèges-Anglas cde133eadd str2bool is not only useful in backup_xva, make it avail. elsewhere. 2014-11-20 15:59:29 +01:00
Jérémie Courrèges-Anglas bea13b4424 Log errors when fetching .xva images 2014-11-20 15:48:56 +01:00
Jérémie Courrèges-Anglas 3ede128155 Simplify url construct. 2014-11-20 15:48:29 +01:00
Jérémie Courrèges-Anglas 059c94797a Tiny optimization for copy_vm_xcp / backup_xva schemes 
Both methods create a snap and make a copy of it, and both methods
ought to be used in the same backup process.  To avoid overwhelming
the storage, it is now possible to avoid deleting a snap in
copy_vm_xcp (delete_snapshot=no) so that it gets reused in
backup_xva (reuse_snapshot=yes).

Requested by Yvan.
 2014-11-20 15:48:00 +01:00
ssamson-tis 639bb15460 Meilleur gestion des backups XenServer 2014-07-25 15:04:10 +02:00
ssamson-tis bd05ae8f25 Fist commit 2013-05-23 10:19:43 +02:00